import { mkdirSync, mkdtempSync, rmSync, writeFileSync } from "node:fs"; import { tmpdir } from "node:os"; import path from "node:path"; import { afterEach, describe, expect, it } from "vitest"; import { createTestSession, type TestSession } from "../../../test/harness"; import { __test } from "../index.ts"; const extensionPath = path.resolve(import.meta.dirname, "../index.ts"); const pairs = [{ executor: "openai/gpt-4o", advisor: "openai/gpt-4o" }]; type Case = { user?: unknown; project?: unknown; untrusted?: boolean }; describe("angel settings resolution", () => { let t: TestSession | undefined; let root: string | undefined; afterEach(() => { t?.dispose(); t = undefined; if (root) rmSync(root, { recursive: true, force: true }); root = undefined; }); async function start(input: Case) { root = mkdtempSync(path.join(tmpdir(), "pi-ext-angel-settings-")); const write = (dir: string, value: unknown) => { mkdirSync(dir, { recursive: true }); writeFileSync( path.join(dir, "settings.json"), JSON.stringify({ angel: value }), ); }; if ("user" in input) write(path.join(root, ".test-home/.pi/agent"), input.user); if ("project" in input) write(path.join(root, ".pi"), input.project); t = await createTestSession({ cwd: root, extensions: [extensionPath] }); if (input.untrusted) t.session.settingsManager.setProjectTrusted(false); // The harness already emitted session_start; count only this start. const before = t.events.uiCallsFor("notify").length; await t.session.extensionRunner.emit({ type: "session_start", reason: "startup", }); const warnings = t.events .uiCallsFor("notify") .slice(before) .filter((call) => call.args[1] === "warning") .map((call) => call.args[0]); return { active: t.session.getActiveToolNames().includes("angel"), warnings, }; } it.each([ ["default unconfigured", {}, false], ["user pairs", { user: { pairs } }, true], ["project pairs", { project: { pairs } }, true], [ "project enabled false merged over user pairs", { user: { pairs }, project: { enabled: false } }, false, ], [ "project enabled true merged over user enabled false", { user: { pairs, enabled: false }, project: { enabled: true } }, true, ], [ "project pairs array replaces user pairs", { user: { pairs }, project: { pairs: [] } }, false, ], [ "untrusted project ignored", { user: { pairs }, project: { enabled: false }, untrusted: true }, true, ], ] satisfies [string, Case, boolean][])( "%s", async (_name, input, expected) => { const { active, warnings } = await start(input); expect(active).toBe(expected); expect(warnings).toEqual([]); }, ); it.each([ [ "non-object project block", { user: { pairs }, project: true }, "Invalid angel from project settings: expected an object", ], [ "merged enabled string", { user: { pairs }, project: { enabled: "false" } }, "Invalid angel from merged project and user settings: enabled must be a boolean", ], [ "user thinkingLevel", { user: { pairs, thinkingLevel: "extreme" } }, "Invalid angel from user settings: thinkingLevel must be one of off, minimal, low, medium, high, xhigh, max", ], [ "user pair shape", { user: { pairs: [{ executor: "openai/gpt-4o" }] } }, "Invalid angel from user settings: pairs must be an array of { executor, advisor } strings", ], [ "user subagentExtensions", { user: { pairs, subagentExtensions: "web" } }, 'Invalid angel from user settings: subagentExtensions must be "all", "none", or an extension-name array', ], ] satisfies [string, Case, string][])( "rejects %s without falling through", async (_name, input, message) => { const { active, warnings } = await start(input); expect(active).toBe(false); expect(warnings).toEqual([`${message}; Angel unconfigured`]); }, ); }); describe("angel sub-agent extensions", () => { it("defaults sub-agent extension loading to none", () => { expect(__test.resolveSubagentExtensions(undefined)).toMatchObject({ all: false, paths: [], }); }); it("resolves a static sibling-extension whitelist", () => { const selection = __test.resolveSubagentExtensions([" web ", "web"]); expect(selection.all).toBe(false); expect(selection.paths).toHaveLength(1); expect(selection.paths[0]?.replaceAll("\\", "/")).toMatch( /extensions\/web\/index\.ts$/, ); }); it("rejects unknown sibling extensions", () => { expect(() => __test.resolveSubagentExtensions(["does-not-exist"])).toThrow( "angel: unknown sub-agent extension: does-not-exist", ); }); });