1 +#
Shame command design 5 +Replace the `review` extension and `/review` command with a shorter, simpler code-review interface named `shame` and `/shame`.
11 +/shame @extensions/super
14 +/shame https://github.com/owner/repo/pull/123
17 +/shame --extra "focus on auth"
20 +Targets require no type keyword.
21 +The old `uncommitted`, `folder`, `branch`, `commit`, and `pr` grammar is removed without aliases.
23 +`--extra <text>` remains available and may follow any target.
27 +Resolve arguments in this order:
29 +1. No target selects the existing smart default: uncommitted changes, current branch against the default branch, then `HEAD`.
30 +2. Tokens beginning with `@` are repo-relative paths after removing `@`.
31 +3. Existing plain paths are also paths.
32 +4. `#<number>` and GitHub pull-request URLs are pull requests.
33 +5. A Git branch ref selects a branch diff.
34 +6. Any other valid Git commit ref selects that commit.
35 +7. Anything unresolved produces one error showing valid examples.
37 +Multiple targets are allowed only when every target is a path.
38 +Missing paths fail before sending the review prompt.
39 +Mixed target kinds fail with a concise error.
43 +`/shame` argument completion offers:
45 +- repo files and directories prefixed with `@`
46 +- local and remote Git branch names
47 +- matching examples for `#<PR>` and `--extra`
49 +Path completion preserves all previously entered path targets and replaces only the active token.
50 +Directories retain a trailing slash so completion can continue into them.
51 +Completion values must account for Pi replacing the complete command argument text.
57 +- `extensions/review/` to `extensions/shame/`
58 +- package `@bugabinga/pi-ext-review` to `@bugabinga/pi-ext-shame`
59 +- command `/review` to `/shame`
60 +- root README, changelog, lockfile entries, tests, and extension documentation
62 +No `/review` alias remains.
64 +##
Review prompt behavior 66 +Keep the existing review rubric, smart-default behavior, project `REVIEW_GUIDELINES.md` loading, and non-mutating PR review behavior.
67 +Only argument parsing, completion, errors, names, and documentation change.
71 +Errors identify the rejected value and show the shortest valid equivalent.
75 +Cannot resolve "super". Try /shame @extensions/super
76 +Cannot mix paths and Git refs in one review
77 +Path not found: extensions/missing
82 +Add focused tests for:
84 +- smart default with no target
85 +- `@` path stripping and multiple paths
86 +- plain existing paths
87 +- PR shorthand and URL recognition
88 +- branch and commit ref classification
89 +- unresolved and mixed-target errors
90 +- path and branch completion
91 +- renamed extension loading in the real Pi harness
93 +Run `mise run ci` before completion.