repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

fix(leaks): restore live tool args

f07acd4482415b68f61f7e59734cecd84350b5ad

Review <review@example.invalid> ·

unsigned

Browse filesCompare with HEAD

Changed files (2)

extensions/leaks/__tests__/pi-direct.test.ts

Modified
96 96 const placeholder =
97 97 JSON.stringify(provider).match(/__LEAK_[A-Z0-9_]+_[a-f0-9]{12}__/)?.[0] ??
99 - const toolEvent = { input: { value: placeholder } };
99 + const rawToolInput = { value: placeholder };
100 + const toolEvent = { input: rawToolInput };
100 101 await runtime.handlers.get("tool_call")?.(toolEvent, view.ctx);
101 102 expect(toolEvent.input.value).toBe(secret);
103 + expect(rawToolInput.value).toBe(secret);
104 + const streamingMessage = {
105 + role: "assistant",
106 + content: [
108 + type: "toolCall",
109 + name: "grep",
110 + arguments: { pattern: placeholder, path: "." },
111 + },
112 + ],
113 + };
114 + await runtime.handlers.get("message_update")?.(
115 + { message: streamingMessage },
116 + view.ctx,
117 + );
118 + expect(streamingMessage.content[0].arguments.pattern).toBe(secret);
119 + const displayArgs = { pattern: placeholder, path: "." };
120 + await runtime.handlers.get("tool_execution_start")?.(
121 + { args: displayArgs },
122 + view.ctx,
123 + );
124 + expect(displayArgs.pattern).toBe(secret);
125 + const updateArgs = { pattern: placeholder, path: "." };
126 + await runtime.handlers.get("tool_execution_update")?.(
127 + { args: updateArgs },
128 + view.ctx,
129 + );
130 + expect(updateArgs.pattern).toBe(secret);
102 131 await runtime.handlers.get("tool_call")?.({}, view.ctx);
103 132 const message = await runtime.handlers.get("message_end")?.(
104 133 { message: placeholder },

extensions/leaks/src/pi.ts

Modified
2 2 import { existsSync, readFileSync } from "node:fs";
3 3 import path from "node:path";
4 4 import type { ExtensionAPI } from "@earendil-works/pi-coding-agent";
5 5 import { LeaksEngine } from "./engine.ts";
6 +import { isPlainObject } from "./safety.ts";
6 7 import { loadLeaksSettings } from "./settings.ts";
8 9 export default function leaks(pi: ExtensionAPI) {
42 43 return result.value;
46 + pi.on("message_update", async (event) => {
47 + restoreEventProperty(engine, event as Record<string, unknown>, "message");
48 + });
45 50 pi.on("tool_call", async (event) => {
46 - const input = (event as { input?: unknown }).input;
47 - if (input !== undefined)
48 - (event as { input: unknown }).input = engine.restoreDeep(input).value;
51 + restoreEventProperty(engine, event as Record<string, unknown>, "input");
52 + });
54 + pi.on("tool_execution_start", async (event) => {
55 + restoreEventProperty(engine, event as Record<string, unknown>, "args");
56 + });
58 + pi.on("tool_execution_update", async (event) => {
59 + restoreEventProperty(engine, event as Record<string, unknown>, "args");
51 62 pi.on("message_end", async (event) => {
105 +function restoreEventProperty(
106 + engine: LeaksEngine,
107 + event: Record<string, unknown>,
108 + key: string,
109 +) {
110 + const current = event[key];
111 + if (current === undefined) return;
112 + const restored = engine.restoreDeep(current).value;
113 + event[key] = restored;
114 + copyRestoredInPlace(current, restored);
117 +function copyRestoredInPlace(target: unknown, source: unknown) {
118 + if (target === source) return;
119 + if (Array.isArray(target) && Array.isArray(source)) {
120 + target.length = 0;
121 + target.push(...source);
122 + return;
124 + if (!isPlainObject(target) || !isPlainObject(source)) return;
125 + for (const key of Object.keys(target)) delete target[key];
126 + Object.assign(target, source);
94 129 function readSettings(cwd: string) {
95 130 const file = path.join(cwd, ".pi", "settings.json");
96 131 if (!existsSync(file)) return { regex: [] };