repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

test(the-system): cover mockup browser round trip

d1db41f0f8502e9396106b61e03f0d621ecb6c16

Oliver Jan Krylow <oliver@bugabinga.net> ·

unsigned

Browse filesCompare with HEAD

Changed files (5)

extensions/the-system/__e2e__/mockup.spec.ts

Added
new file mode 100644
1 +import { expect, test } from "@playwright/test";
2 +import {
3 + type MockupResult,
4 + type MockupServer,
5 + startMockupServer,
6 +} from "../mockup.ts";
8 +let server: MockupServer | undefined;
10 +test.afterEach(() => {
11 + if (!server) return;
12 + server.result.catch(() => undefined);
13 + server.close("e2e cleanup");
14 + server = undefined;
15 +});
17 +test("renders options and returns browser feedback", async ({ page }) => {
18 + server = await startMockupServer(
19 + {
20 + title: "Layout review",
21 + question: "Which layout works?",
22 + options: [
23 + {
24 + id: "dense",
25 + label: "Dense",
26 + description: "Compact layout",
27 + html:
28 + '<section><button id="fragment-action">Dense content</button></section>',
29 + },
30 + {
31 + id: "calm",
32 + label: "Calm",
33 + html: "<section>Calm content</section>",
34 + },
35 + ],
36 + },
37 + { openBrowser: false },
38 + );
40 + await page.goto(server.url);
41 + await expect(
42 + page.getByRole("heading", { name: "Layout review" }),
43 + ).toBeVisible();
44 + await expect(page.getByText("Which layout works?")).toBeVisible();
45 + await expect(page.locator(".option-card")).toHaveCount(2);
46 + await expect(page.getByText("Dense content")).toBeVisible();
48 + await page.locator('[data-select-option="dense"]').check();
49 + await expect(page.locator("#selection-summary")).toHaveText("Selected: dense");
50 + await page.locator("#global-notes").fill("keep dense");
52 + await page.locator('[data-pin-option="dense"]').click();
53 + await page.locator('[data-fragment="dense"]').click({
54 + position: { x: 40, y: 40 },
55 + });
56 + await page.getByLabel("Pin note").fill("tighten spacing");
58 + const submitted = server.result;
59 + await page.locator("#accept").click();
60 + await expect(page.getByRole("heading", { name: "Sent to Pi" })).toBeVisible();
62 + const result: MockupResult = await submitted;
63 + expect(result).toMatchObject({
64 + action: "accept",
65 + selected: ["dense"],
66 + notes: "keep dense",
67 + annotations: [
68 + {
69 + optionId: "dense",
70 + note: "tighten spacing",
71 + },
72 + ],
73 + });
74 + expect(result.annotations[0].x).toBeGreaterThan(0);
75 + expect(result.annotations[0].x).toBeLessThanOrEqual(1);
76 + expect(result.annotations[0].y).toBeGreaterThan(0);
77 + expect(result.annotations[0].y).toBeLessThanOrEqual(1);
78 +});

extensions/the-system/mockup.ts

Modified
91 91 return new Text(lines.join("\n"), 0, 0);
93 - renderResult(result, theme, context) {
93 + renderResult(result, context, theme) {
94 94 const details = result.details as Partial<MockupResult> | undefined;
95 95 if (!details) return new Text("", 0, 0);
96 96 const summary = `${details.action ?? "submitted"} · ${(details.selected ?? []).join(", ") || "none"} · ${(details.annotations ?? []).length} annotation${(details.annotations ?? []).length === 1 ? "" : "s"}`;
340 340 if (!isRecord(value)) throw new Error("submit body must be an object");
341 341 const action = enumString(
342 342 value.action,
343 - new Set(["accept", "iterate"]),
343 + new Set<MockupResult["action"]>(["accept", "iterate"]),
344 344 "action",
346 346 if (!Array.isArray(value.selected))

extensions/the-system/package.json

Modified
20 20 "devDependencies": {
21 21 "@marcfargas/pi-test-harness": "^0.6.1",
22 + "@playwright/test": "^1.61.0",
22 23 "vitest": "^4.1.9"
24 25 "scripts": {

extensions/the-system/playwright.config.ts

Added
new file mode 100644
1 +import { defineConfig } from "@playwright/test";
2 +import base from "../../test/playwright.base.ts";
4 +export default defineConfig(base, {
5 + testDir: "./__e2e__",
6 + testMatch: "*.spec.ts",
7 + timeout: 30_000,
8 + expect: { timeout: 5_000 },
9 +});

package-lock.json

Modified
455 455 "license": "MIT",
456 456 "devDependencies": {
457 457 "@marcfargas/pi-test-harness": "^0.6.1",
458 + "@playwright/test": "^1.61.0",
458 459 "vitest": "^4.1.9"
460 461 "peerDependencies": {