repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

fix(diff-review): disable opener under vitest

a0ebd5cb1930cf62448a9a8992e979cdeffa704f

Oliver Krylow <o.krylow@isp-insoft.de> ·

unsigned

Browse filesCompare with HEAD

Changed files (2)

extensions/diff-review/__tests__/core.test.ts

Modified
48 + it("does not spawn browser openers in isolated Vitest harness env", async () => {
49 + const oldNodeEnv = process.env.NODE_ENV;
50 + const oldVitest = process.env.VITEST;
51 + try {
52 + delete process.env.NODE_ENV;
53 + process.env.VITEST = "true";
54 + await expect(openBrowser("http://127.0.0.1:1/")).resolves.toEqual({
55 + ok: false,
56 + error: "Browser opener disabled",
57 + });
58 + } finally {
59 + if (oldNodeEnv === undefined) delete process.env.NODE_ENV;
60 + else process.env.NODE_ENV = oldNodeEnv;
61 + if (oldVitest === undefined) delete process.env.VITEST;
62 + else process.env.VITEST = oldVitest;
63 + }
64 + });
48 66 it("preserves staged rename metadata when collecting per-file diffs", async () => {
49 67 const repo = await tempRepo();
50 68 await writeFile(join(repo, "old.txt"), "one\n");

extensions/diff-review/open-browser.ts

Modified
3 3 import { spawn } from "node:child_process";
5 5 export async function openBrowser(
6 6 url: string,
7 7 ): Promise<{ ok: boolean; command?: string; error?: string }> {
8 - if (process.env.NODE_ENV === "test" || process.env.PI_DIFF_REVIEW_NO_OPEN)
8 + if (
9 + process.env.NODE_ENV === "test" ||
10 + process.env.VITEST ||
11 + process.env.PI_DIFF_REVIEW_NO_OPEN
12 + )
9 13 return { ok: false, error: "Browser opener disabled" };
11 15 const candidates = openerCandidates(url);