repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

fix(diff-review): update pierre diffs theme registration

86b3a230f7e7e3dc2eb400f2c6026d0c99c73721

Oliver Jan Krylow <oliver@bugabinga.net> ·

unsigned

Browse filesCompare with HEAD

Changed files (3)

extensions/diff-review/__tests__/pierre-theme-regression.test.ts

Added
new file mode 100644
1 +import { dirname, join } from "node:path";
2 +import { fileURLToPath, pathToFileURL } from "node:url";
3 +import { describe, expect, it, vi } from "vitest";
5 +function sharedHighlighterUrl(tag: string) {
6 + const diffsEntry = fileURLToPath(import.meta.resolve("@pierre/diffs"));
7 + return `${pathToFileURL(join(dirname(diffsEntry), "highlighter/shared_highlighter.js")).href}?${tag}`;
8 +}
10 +describe("@pierre/diffs theme registration", () => {
11 + it("does not log duplicate Pierre built-in themes when highlighter module is reloaded", async () => {
12 + const error = vi.spyOn(console, "error").mockImplementation(() => {});
13 + let duplicateLogs: unknown[][] = [];
14 + try {
15 + await import(sharedHighlighterUrl("first"));
16 + await import(sharedHighlighterUrl("second"));
17 + duplicateLogs = error.mock.calls.filter(
18 + (call) =>
19 + call[0] ===
20 + "SharedHighlight.registerCustomTheme: theme name already registered",
21 + );
22 + } finally {
23 + error.mockRestore();
24 + }
26 + expect(duplicateLogs).toEqual([]);
27 + });
28 +});

extensions/diff-review/package.json

Modified
7 7 "test:e2e": "playwright test --config playwright.config.ts"
9 9 "dependencies": {
10 - "@pierre/diffs": "^1.1.22",
10 + "@pierre/diffs": "^1.2.9",
11 11 "@pierre/trees": "^1.0.0-beta.4"
13 13 "peerDependencies": {

package-lock.json

Modified
100 100 "name": "@bugabinga/pi-ext-diff-review",
101 101 "license": "MIT",
102 102 "dependencies": {
103 - "@pierre/diffs": "^1.1.22",
103 + "@pierre/diffs": "^1.2.9",
104 104 "@pierre/trees": "^1.0.0-beta.4"
106 106 "devDependencies": {
3196 3196 "node_modules/@pierre/diffs": {
3197 - "version": "1.2.7",
3198 - "resolved": "https://registry.npmjs.org/@pierre/diffs/-/diffs-1.2.7.tgz",
3199 - "integrity": "sha512-YrHmFZLDtiLZ4DkiVqMDUFqTFIct3ML3t20nMp0UeuiUtqrmRcenYVxPb4IafiNkhZZURhCiwcs89tVb/HrSDA==",
3197 + "version": "1.2.9",
3198 + "resolved": "https://registry.npmjs.org/@pierre/diffs/-/diffs-1.2.9.tgz",
3199 + "integrity": "sha512-nqpU6BGb6mUiYnu0lDG2BVH0aKFDCQpFD/SwcY5spy395RVKJDmS5uk0mE1q+EPq1cqOEdo72DUXmty4VsvaVA==",
3200 3200 "license": "apache-2.0",
3201 3201 "dependencies": {
3202 3202 "@pierre/theme": "1.0.3",
3203 + "@pierre/theming": "0.0.1",
3203 3204 "@shikijs/transformers": "^3.0.0",
3204 3205 "diff": "8.0.3",
3205 3206 "hast-util-to-html": "9.0.5",
3220 3221 "vscode": "^1.0.0"
3224 + "node_modules/@pierre/theming": {
3225 + "version": "0.0.1",
3226 + "resolved": "https://registry.npmjs.org/@pierre/theming/-/theming-0.0.1.tgz",
3227 + "integrity": "sha512-1thlEtJbqdyLzc1ZS2KQa1q7FzDGHT4dTEdKHoyQjOMeWWOmbVG5/ndEfOKfAb5Fzkz8cNJrOjFLiZoDH/A03A==",
3228 + "license": "apache-2.0",
3229 + "peerDependencies": {
3230 + "@pierre/theme": "^1.0.0",
3231 + "@shikijs/themes": "^3.0.0 || ^4.0.0",
3232 + "react": "^18.3.1 || ^19.0.0",
3233 + "react-dom": "^18.3.1 || ^19.0.0",
3234 + "shiki": "^3.0.0 || ^4.0.0"
3235 + },
3236 + "peerDependenciesMeta": {
3237 + "@pierre/theme": {
3238 + "optional": true
3239 + },
3240 + "@shikijs/themes": {
3241 + "optional": true
3242 + },
3243 + "react": {
3244 + "optional": true
3245 + },
3246 + "react-dom": {
3247 + "optional": true
3248 + },
3249 + "shiki": {
3250 + "optional": true
3253 + },
3223 3254 "node_modules/@pierre/trees": {
3224 3255 "version": "1.0.0-beta.4",
3225 3256 "resolved": "https://registry.npmjs.org/@pierre/trees/-/trees-1.0.0-beta.4.tgz",