pi-ext
bugabingas pi extensions
owned by bugabinga
fix(diff-review): restore live reviews only on command
7bb08cd7a5dfc4a0dd0aaf6ada72bd5a95ae6f49
Oliver Jan Krylow <oliver@bugabinga.net> ·
unsigned
Browse filesCompare with HEAD
Changed files (2)
extensions/diff-review/__tests__/harness.test.ts
Modified27 27 expect(t.session.extensionRunner.extensions[
0].path).
toBe(extensionPath);
30 + it(
"does not auto-restore a persisted live review on session_start",
async ()
=> {
31 + const extensionPath
= path.
resolve(
import.
meta.
dir,
"../index.ts");
32 + t
= await createTestSession({ extensions: [extensionPath] });
33 + (t.session.sessionManager
as any).
appendCustomEntry(
"diff-review", {
39 + args: { staged:
false },
41 + createdAt:
new Date().
toISOString(),
43 + const statusCount
= t.events.
uiCallsFor(
"setStatus").
length;
44 + const notifyCount
= t.events.
uiCallsFor(
"notify").
length;
46 + await t.session.extensionRunner.
emit({
47 + type:
"session_start",
54 + .
uiCallsFor(
"setStatus")
56 + .
filter((call)
=> call.args[
0]
=== "diff-review"),
58 + expect(t.events.
uiCallsFor(
"notify").
slice(notifyCount)).
toEqual([]);
30 61 it(
"does not mutate UI after shutdown closes an active review server",
async ()
=> {
31 62 const extensionPath
= path.
resolve(
import.
meta.
dir,
"../index.ts");
32 63 t
= await createTestSession({ extensions: [extensionPath] });
extensions/diff-review/index.ts
Modified 34 34 `${open} open review finding${open === 1 ? "" : "s"}`,
36 - if (state.live
&& ctx.hasUI)
37 - restoring
= restoreLiveReview(ctx, state.live).
finally(()
=> {
38 - restoring
= undefined;
42 38 pi.
on(
"session_shutdown",
async ()
=> {