repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

ci: use playwright image dependencies

78c9e45a9e9ecbaf9593c9216b55f6fcb07cd60b

Oliver Jan Krylow <oliver@bugabinga.net> ·

unsigned

Browse filesCompare with HEAD

Changed files (2)

docs/super/plans/2026-07-12-mise-task-architecture-phase-4-tune-e2e-ci.md

Modified
4 4 # Mise Task Architecture Phase 4 Implementation Plan
6 6 > **For agentic workers:** REQUIRED SUB-SKILL: Use /skill:executing-plans to implement this plan task-by-task. Steps use checkbox (`- [ ]`) syntax for tracking.
8 8 **Goal:** Cover tune’s live dashboard in Chromium and Firefox, make all four browser suites mandatory in CI, and finalize the root task surface.
10 -**Architecture:** Extract tune’s embedded dashboard HTTP/SSE server into one focused module used by production and Playwright. Tune owns its local suite and task, while root mise installs browser system dependencies only under CI and runs the release gate in `check → lint → test → e2e` order.
10 +**Architecture:** Extract tune’s embedded dashboard HTTP/SSE server into one focused module used by production and Playwright. Tune owns its local suite and task, while the Luci image owns browser system dependencies and root mise runs the release gate in `check → lint → test → e2e` order.
12 12 **Tech Stack:** Playwright 1.61, Chromium, Firefox, Node HTTP/SSE, mise monorepo tasks, TypeScript, Luci, Podman.
488 488 Expected: lint, test, and check appear; E2E does not.
490 -- [ ] **Step 2: Install browser system dependencies only under CI**
490 +- [ ] **Step 2: Keep browser system dependencies outside the cross-platform task**
492 -In root `tasks.e2e`, replace the browser install command with this templated value:
492 +In root `tasks.e2e`, use the same browser-engine install command everywhere:
494 494 ```toml
495 -"npm exec -- playwright install{% if env.CI %} --with-deps{% endif %} chromium firefox",
495 +"npm exec -- playwright install chromium firefox",
498 498 Local `mise run e2e` downloads browser engines without mutating host system packages.
499 -Luci runs the job with `CI=true`, so the same root task uses Playwright’s supported dependency installation path.
499 +Luci’s pinned Playwright image supplies its Linux system dependencies.
501 501 - [ ] **Step 3: Set the final release-gate order**
527 527 Expected:
529 -- Local E2E install omits `--with-deps`.
529 +- E2E browser installation omits `--with-deps`.
530 530 - CI order is check, lint, test, e2e.
531 531 - Root E2E discovers diff-review, UI, the-system, and tune.
533 -Run:
535 -```bash
536 -CI=true mise run --dry-run e2e
537 -```
539 -Expected: browser install includes `--with-deps`.
541 533 - [ ] **Step 5: Migrate repository CI to Luci**
543 535 Delete `.github/workflows/check.yml`.

mise.toml

Modified
60 60 description = "Run all extension browser E2E tests"
61 61 depends = ["install"]
62 62 run = [
63 - "npm exec -- playwright install{% if env.CI %} --with-deps{% endif %} chromium firefox",
63 + "npm exec -- playwright install chromium firefox",
64 64 "mise run --jobs 1 //extensions/...:e2e",