repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

test: isolate nested git commands

554c76bb3c7aada5ddb5bbc003c3ad6b4c77fbff

Review <review@example.invalid> ·

unsigned

Browse filesCompare with HEAD

Changed files (5)

.markdownlint-cli2.yaml

Modified
4 4 globs:
5 5 - "**/*.md"
6 6 ignores:
7 7 - "**/node_modules/**"
8 8 - ".demo/**"
9 9 - "skills/*/references/**"
10 + - "skills/*/_research/**"
10 11 - "skills/presenterm/templates/**"
11 12 config:
12 13 MD013: false

extensions/diff-review/__tests__/core.test.ts

Modified
12 12 const execFileAsync = promisify(execFile);
13 13 const tempDirs: string[] = [];
14 +const GIT_LOCAL_ENV = [
15 + "GIT_ALTERNATE_OBJECT_DIRECTORIES",
16 + "GIT_CONFIG",
17 + "GIT_CONFIG_PARAMETERS",
18 + "GIT_CONFIG_COUNT",
19 + "GIT_OBJECT_DIRECTORY",
20 + "GIT_DIR",
21 + "GIT_WORK_TREE",
22 + "GIT_IMPLICIT_WORK_TREE",
23 + "GIT_GRAFT_FILE",
24 + "GIT_INDEX_FILE",
25 + "GIT_NO_REPLACE_OBJECTS",
26 + "GIT_REPLACE_REF_BASE",
27 + "GIT_PREFIX",
28 + "GIT_SHALLOW_FILE",
29 + "GIT_COMMON_DIR",
30 +] as const;
15 32 afterEach(async () => {
16 33 await Promise.all(
30 47 async function git(cwd: string, args: string[]) {
31 - await execFileAsync("git", args, { cwd, maxBuffer: 20 * 1024 * 1024 });
48 + await execFileAsync("git", args, {
49 + cwd,
50 + env: cleanGitEnv(),
51 + maxBuffer: 20 * 1024 * 1024,
52 + });
55 +function cleanGitEnv() {
56 + const env = { ...process.env };
57 + for (const key of GIT_LOCAL_ENV) delete env[key];
58 + return env;
34 61 describe("diff-review core regressions", () => {

extensions/diff-review/__tests__/harness.test.ts

Modified
7 7 import diffReviewExtension from "../index";
9 9 const execFileAsync = promisify(execFile);
10 +const GIT_LOCAL_ENV = [
11 + "GIT_ALTERNATE_OBJECT_DIRECTORIES",
12 + "GIT_CONFIG",
13 + "GIT_CONFIG_PARAMETERS",
14 + "GIT_CONFIG_COUNT",
15 + "GIT_OBJECT_DIRECTORY",
16 + "GIT_DIR",
17 + "GIT_WORK_TREE",
18 + "GIT_IMPLICIT_WORK_TREE",
19 + "GIT_GRAFT_FILE",
20 + "GIT_INDEX_FILE",
21 + "GIT_NO_REPLACE_OBJECTS",
22 + "GIT_REPLACE_REF_BASE",
23 + "GIT_PREFIX",
24 + "GIT_SHALLOW_FILE",
25 + "GIT_COMMON_DIR",
26 +] as const;
10 27 const sleep = (ms: number) => new Promise((resolve) => setTimeout(resolve, ms));
12 29 describe("diff-review pi-test-harness", () => {
103 120 async function git(cwd: string, args: string[]) {
104 - await execFileAsync("git", args, { cwd, maxBuffer: 20 * 1024 * 1024 });
121 + await execFileAsync("git", args, {
122 + cwd,
123 + env: cleanGitEnv(),
124 + maxBuffer: 20 * 1024 * 1024,
125 + });
128 +function cleanGitEnv() {
129 + const env = { ...process.env };
130 + for (const key of GIT_LOCAL_ENV) delete env[key];
131 + return env;

extensions/diff-review/git.ts

Modified
16 16 const STDERR_BUFFER_BYTES = 64 * 1024;
17 17 const HUNK_HEADER = /^@@ -(\d+)(?:,\d+)? \+(\d+)(?:,\d+)? @@/;
18 18 const DIFF_GIT_HEADER = /^diff --git a\/(.*) b\/(.*)$/;
19 +const GIT_LOCAL_ENV = [
20 + "GIT_ALTERNATE_OBJECT_DIRECTORIES",
21 + "GIT_CONFIG",
22 + "GIT_CONFIG_PARAMETERS",
23 + "GIT_CONFIG_COUNT",
24 + "GIT_OBJECT_DIRECTORY",
25 + "GIT_DIR",
26 + "GIT_WORK_TREE",
27 + "GIT_IMPLICIT_WORK_TREE",
28 + "GIT_GRAFT_FILE",
29 + "GIT_INDEX_FILE",
30 + "GIT_NO_REPLACE_OBJECTS",
31 + "GIT_REPLACE_REF_BASE",
32 + "GIT_PREFIX",
33 + "GIT_SHALLOW_FILE",
34 + "GIT_COMMON_DIR",
35 +] as const;
20 37 type ChangedFileSpec = { paths: string[]; displayPath: string };
159 176 const { stdout } = await execFileAsync("git", args, {
178 + env: cleanGitEnv(),
161 179 maxBuffer: options.maxBuffer ?? DEFAULT_GIT_BUFFER_BYTES,
163 181 return String(stdout);
174 192 return new Promise((resolve, reject) => {
175 193 const child = spawn("git", args, {
195 + env: cleanGitEnv(),
177 196 stdio: ["ignore", "pipe", "pipe"],
179 198 const stdout: Buffer[] = [];
245 +function cleanGitEnv() {
246 + const env = { ...process.env };
247 + for (const key of GIT_LOCAL_ENV) delete env[key];
248 + return env;
226 251 function gitError(err: unknown) {
227 252 const e = err as { stderr?: string | Buffer; message?: string };
228 253 return String(e.stderr ?? "").trim() || e.message || "git failed";

vitest.config.ts

Modified
7 7 reporters: ["minimal"],
8 8 testTimeout: 30_000,
9 9 hookTimeout: 30_000,
10 - // Reuse fork workers across files: this suite passed under shared module state
11 - // and avoids repeating TypeScript/Vite imports for every test file.
12 - isolate: false,
13 - // Three fork workers avoid CPU/process contention with shared worker modules.
10 + // Three fork workers avoid CPU/process contention.
14 11 maxWorkers: 3,