pi-ext
bugabingas pi extensions
owned by bugabinga
docs: record mockup typecheck fixes
4bc524157a352b0fc31b1546d7cb16a930d47021
Oliver Jan Krylow <oliver@bugabinga.net> ·
unsigned
Browse filesCompare with HEAD
Changed files (1)
docs/super/plans/2026-07-12-mise-task-architecture-phase-3-mockup-e2e.md
Modified 27 27 - `extensions/the-system/package.json`: declare Playwright as a development dependency.
28 +- `extensions/the-system/mockup.ts`: fix renderer argument order and preserve the submitted-action literal type exposed by E2E typechecking.
28 29 - `package-lock.json`: record the workspace dependency.
29 30 - `extensions/the-system/README.md`: document local and aggregate E2E commands.
33 -- `extensions/the-system/mockup.ts`: the exported server already exposes a deterministic `openBrowser: false` path.
34 34 - Existing mockup Vitest tests remain the detailed validation and protocol suite.
35 35 - Root `mise.toml`: its Phase 2 wildcard automatically discovers the new local task.
36 36 - Root `ci`: E2E remains outside CI until Phase 4.
42 42 - Create: `extensions/the-system/playwright.config.ts`
43 43 - Create: `extensions/the-system/__e2e__/mockup.spec.ts`
44 +- Modify: `extensions/the-system/mockup.ts`
44 45 - Modify: `extensions/the-system/package.json`
45 46 - Modify: `package-lock.json`
206 207 Expected: the round trip passes in Chromium and Firefox.
207 208 No desktop browser opens because the test calls the supported `openBrowser: false` path.
209 -- [ ] **Step 8: Commit the browser contract**
210 +- [ ] **Step 8: Fix type errors exposed by the E2E import**
212 +Run `mise run check`.
213 +Expected baseline: FAIL in `mockup.ts` because the previously excluded module has reversed `renderResult` arguments and a widened action set.
215 +Change `renderResult(result, theme, context)` to `renderResult(result, context, theme)`.
216 +Change `new Set(["accept", "iterate"])` to `new Set<MockupResult["action"]>(["accept", "iterate"])`.
217 +Run `mise run check` again.
220 +- [ ] **Step 9: Commit the browser contract**
214 -git add extensions/the-system/playwright.config.ts extensions/the-system/__e2e__/mockup.spec.ts extensions/the-system/package.json package-lock.json
225 +git add extensions/the-system/playwright.config.ts extensions/the-system/__e2e__/mockup.spec.ts extensions/the-system/mockup.ts extensions/the-system/package.json package-lock.json
215 226 git diff --cached --check
216 227 git commit -m
"test(the-system): cover mockup browser round trip"