repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

Coalesce ui streamed messages

37b3ba24053fa2d216a73c1ef5bf16d119b8485a

Oliver Krylow <o.krylow@isp-insoft.de> ·

unsigned

Browse filesCompare with HEAD

Changed files (5)

extensions/ui/__tests__/rendering.test.ts

Modified
32 32 expect(renderDiffViewJs()).toContain("import('pierre')");
35 + it("coalesces streaming message updates by stream id", () => {
36 + const js = renderAppJs();
37 + expect(js).toContain("event.streamId");
38 + expect(js).toContain("replaceWith(row)");
39 + });
41 + it("does not locally echo submitted prompts", () => {
42 + const js = renderAppJs();
43 + expect(js).not.toContain(
44 + "Number.MAX_SAFE_INTEGER, at: Date.now(), type: 'message', role: 'user'",
45 + );
46 + });
35 48 it("keeps internal runtime chatter out of the main stream", () => {
36 49 const js = renderAppJs();
37 50 expect(js).toContain("isStreamEvent(event)");

extensions/ui/__tests__/runtime.test.ts

Modified
67 67 normalizeRpcEvent({ type: "startup_log", message: "builtin-tools" }),
68 68 ).toBeUndefined();
71 + it("uses accumulated assistant text for streaming updates", () => {
72 + expect(
73 + normalizeRpcEvent({
74 + type: "message_update",
75 + message: {
76 + role: "assistant",
77 + content: [{ type: "text", text: "Ready. What" }],
78 + },
79 + assistantMessageEvent: {
80 + type: "text_delta",
81 + contentIndex: 0,
82 + delta: " What",
83 + },
84 + }),
85 + ).toEqual({
86 + type: "message",
87 + role: "assistant",
88 + text: "Ready. What",
89 + streamId: "assistant-stream",
90 + });
91 + });
72 94 describe("ui runtime", () => {

extensions/ui/protocol.ts

Modified
29 29 type: "message";
30 30 role: "user" | "assistant" | "tool" | "system";
31 31 text: string;
32 + streamId?: string;
34 35 export type UiToolEvent = UiEventBase & {

extensions/ui/runtime.ts

Modified
384 384 return {
385 385 type: "message",
386 386 role: "assistant",
387 - text: event.assistantMessageEvent.delta,
387 + text: assistantText(event.message),
388 + streamId: "assistant-stream",
390 391 if (isRpcToolEvent(event)) {
402 403 return undefined;
406 +function assistantText(message: unknown): string {
407 + if (!message || typeof message !== "object") return "";
408 + const content = (message as { content?: unknown }).content;
409 + if (!Array.isArray(content)) return "";
410 + return content
411 + .map((item) =>
412 + item &&
413 + typeof item === "object" &&
414 + typeof (item as { text?: unknown }).text === "string"
415 + ? (item as { text: string }).text
416 + : "",
418 + .join("");
405 421 function isRpcMessageUpdate(
406 422 event: unknown,
407 -): event is { assistantMessageEvent: { delta: string } } {
423 +): event is { message: unknown; assistantMessageEvent: { delta: string } } {
408 424 return (
409 425 !!event &&
410 426 typeof event === "object" &&

extensions/ui/web/app.js.ts

Modified
95 95 const row = document.createElement('article');
96 96 row.className = 'ui-event ui-event-' + (event.role || event.type);
97 97 row.dataset.eventId = String(event.id);
98 + if (event.streamId) row.dataset.streamId = String(event.streamId);
98 99 const eventText = event.text || event.message || event.state || '';
99 - applyLongOutput(row, String(event.id), String(eventText));
100 + applyLongOutput(row, String(event.streamId || event.id), String(eventText));
100 101 const fence = String.fromCharCode(96).repeat(3);
101 102 if (typeof eventText === 'string' && eventText.startsWith(fence)) {
102 103 row.textContent = '';
111 112 if (event.type === 'ui_request') renderUiRequest(row, event);
112 113 if (event.type && event.type.startsWith('widget_')) renderVisualBlock(row, event);
113 - fragment.append(row);
114 + const existing = event.streamId ? stream.querySelector('[data-stream-id="' + CSS.escape(String(event.streamId)) + '"]') : null;
115 + if (existing) existing.replaceWith(row);
116 + else fragment.append(row);
115 118 appendStreamRows(fragment);
116 119 streamBatchChannel.port2.postMessage('flush');
222 225 if (!text || !socket || socket.readyState !== WebSocket.OPEN) return;
223 226 send.disabled = true;
224 227 socket.send(JSON.stringify({ type: 'prompt', text }));
225 - renderEvents([{ id: Number.MAX_SAFE_INTEGER, at: Date.now(), type: 'message', role: 'user', text }]);
226 228 input.value = '';
227 229 setDigestIndicator(0);
228 230 send.disabled = false;