repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by admin

fix: fall back to exclusive create when hard links are unsupported

2a01b347e969186992fc2c9989a2643f8cf5a5e4

Oliver Jan Krylow <oliver@bugabinga.net> ·

SSH signature · not checked

Browse filesCompare with HEAD

Android SELinux denies link() to app domains, breaking gj startup
migration and bak restore with EACCES. Keep hard links where supported
and fall back to O_EXCL writes on EACCES, EPERM, ENOSYS, EOPNOTSUPP,
EXDEV, and EMLINK. EEXIST duplicate semantics are unchanged.

Changed files (2)

extensions/bak/archive.ts

Modified
305 +function isLinkUnsupported(error: unknown): boolean {
306 + if (!(error instanceof Error && "code" in error)) return false;
307 + const { code } = error as NodeJS.ErrnoException;
308 + return (
309 + code === "EACCES" ||
310 + code === "EPERM" ||
311 + code === "ENOSYS" ||
312 + code === "EOPNOTSUPP" ||
313 + code === "EXDEV" ||
314 + code === "EMLINK"
315 + );
318 +async function exclusiveWrite(
319 + path: string,
320 + body: Uint8Array,
321 +): Promise<boolean> {
322 + try {
323 + await writeFile(path, body, { mode: 0o600, flag: "wx" });
324 + return true;
325 + } catch (error) {
326 + if ((error as NodeJS.ErrnoException).code === "EEXIST") return false;
327 + throw error;
305 331 async function publishNoReplace(
306 332 path: string,
307 333 body: Uint8Array,
318 344 return true;
319 345 } catch (error) {
320 346 if ((error as NodeJS.ErrnoException).code === "EEXIST") return false;
321 - throw error;
347 + // Android SELinux and some filesystems forbid hard links.
348 + if (!isLinkUnsupported(error)) throw error;
349 + return exclusiveWrite(path, body);
323 351 } finally {
324 352 await unlink(temporary).catch(() => undefined);

extensions/good-job/storage.ts

Modified
180 +function isLinkUnsupported(error: unknown): boolean {
181 + if (!isNodeError(error)) return false;
182 + return (
183 + error.code === "EACCES" ||
184 + error.code === "EPERM" ||
185 + error.code === "ENOSYS" ||
186 + error.code === "EOPNOTSUPP" ||
187 + error.code === "EXDEV" ||
188 + error.code === "EMLINK"
189 + );
192 +async function exclusiveCreateJson(
193 + target: string,
194 + value: unknown,
195 +): Promise<void> {
196 + const file = await open(target, "wx", 0o600);
197 + try {
198 + await file.writeFile(`${JSON.stringify(value)}\n`, "utf8");
199 + await file.sync();
200 + } finally {
201 + await file.close();
180 205 export async function atomicCreateJson(
181 206 target: string,
182 207 value: unknown,
183 208 ): Promise<void> {
184 209 const temporary = await temporaryJson(target, value);
186 - await link(temporary, target);
211 + try {
212 + await link(temporary, target);
213 + } catch (error) {
214 + // Android SELinux and some filesystems forbid hard links.
215 + if (!isLinkUnsupported(error)) throw error;
216 + await exclusiveCreateJson(target, value);
187 218 await rm(temporary, { force: true });
188 219 await syncDirectory(dirname(target));
189 220 } catch (error) {