repositories / pi-ext

pi-ext

bugabingas pi extensions

owned by bugabinga

fix(leaks): recover after buffered session flush

270adee85baf6c0decef20f35307f53d900c83c5

Oliver Jan Krylow <oliver@bugabinga.net> ·

unsigned

Browse filesCompare with HEAD

Changed files (6)

extensions/leaks/__fuzz__/builtins.fuzz.test.ts

Modified
119 119 "OPENAI_TOKEN",
120 120 "ANTHROPIC_TOKEN",
121 121 "GOOGLE_API_KEY",
122 + "SENDGRID_TOKEN",
123 + "OAUTH_TOKEN",
124 126 for (const [index, [tag, build]] of cases.entries()) {

extensions/leaks/__tests__/corpus.test.ts

Modified
13 13 .split("\0")
14 14 .filter(Boolean)
15 15 .filter((file) =>
16 - /(?:\.(?:ts|js|mjs|qml|lua|html|css|md|json|jsonc|kdl|toml|ya?ml|sh|nu)|(?:^|\/)package-lock\.json)$/.test(
16 + /(?:\.(?:ts|js|mjs|qml|lua|html|css|md|json|jsonc|kdl|toml|ya?ml|sh|nu)|(?:^|\/)(?:package-lock\.json|mise\.lock))$/.test(
17 17 file,

extensions/leaks/__tests__/detectors.test.ts

Modified
132 132 __test.findBuiltinSpans(`sk-ant-api03-${"A".repeat(31)}_`),
133 133 ).toHaveLength(1);
134 134 expect(__test.findBuiltinSpans(`AIza${"A".repeat(34)}-`)).toHaveLength(1);
135 + expect(
136 + __test.findBuiltinSpans(`SG.${"A".repeat(16)}.${"A".repeat(31)}-`),
137 + ).toHaveLength(1);
138 + expect(__test.findBuiltinSpans(`ya29.${"A".repeat(31)}-`)).toHaveLength(1);
137 141 it("validates age checksums and minisign payload encoding", () => {

extensions/leaks/__tests__/pi-direct.test.ts

Modified
240 240 const sessionFile = path.join(view.ctx.cwd, "buffered-session.jsonl");
241 241 writeFileSync(sessionFile, "");
242 242 const branch: Array<Record<string, unknown>> = [];
243 + let flushed = false;
243 244 const runtime = fakePi((customType, data) => {
244 - branch.push({
245 + const entry = {
245 246 id: `buffered-${branch.length}`,
246 247 type: "custom",
247 248 customType,
249 - });
250 + };
251 + branch.push(entry);
252 + if (flushed) appendFileSync(sessionFile, `${JSON.stringify(entry)}\n`);
251 254 leaks(runtime.pi as never);
252 255 const ctx = {
265 268 expect(JSON.stringify(result)).toContain(secret);
269 + writeFileSync(
270 + sessionFile,
271 + branch.map((entry) => JSON.stringify(entry)).join("\n") + "\n",
272 + );
273 + flushed = true;
274 + await runtime.commands.get("leaks")?.handler("reload", ctx);
275 + const afterFlush = await runtime.handlers.get("before_provider_request")?.(
276 + { payload: { text: secret } },
277 + ctx,
278 + );
279 + expect(JSON.stringify(afterFlush)).not.toContain(secret);
268 282 it("rejects failed-append ghosts after a fresh runtime reload", async () => {

extensions/leaks/src/detectors.ts

Modified
67 67 "sendgrid",
68 68 "SENDGRID_TOKEN",
69 69 "mail",
70 - /\bSG\.[A-Za-z0-9_-]{16,}\.[A-Za-z0-9_-]{32,}\b/dg,
70 + /(?<![A-Za-z0-9_-])SG\.[A-Za-z0-9_-]{16,}\.[A-Za-z0-9_-]{32,}(?![A-Za-z0-9_-])/dg,
71 + ),
72 + rule(
73 + "oauth-google",
74 + "OAUTH_TOKEN",
75 + "auth",
76 + /(?<![A-Za-z0-9_-])ya29\.[A-Za-z0-9_-]{32,}(?![A-Za-z0-9_-])/dg,
72 - rule("oauth-google", "OAUTH_TOKEN", "auth", /\bya29\.[A-Za-z0-9_-]{32,}\b/dg),
73 78 rule(
74 79 "pgp-private",
75 80 "PGP_PRIVATE_KEY",

extensions/leaks/src/pi.ts

Modified
9 9 import { isPlainObject, sanitizeTag } from "./safety.ts";
10 10 import { loadLeaksSettings } from "./settings.ts";
12 +class NondurableAppendError extends Error {}
12 14 export default function leaks(pi: ExtensionAPI) {
13 15 const engine = new LeaksEngine();
14 16 const reportedWarnings = new Set<string>();
355 357 "session entry is not durable yet; values remain visible (run /reload after the first assistant message)",
356 358 "warning",
358 - throw new Error("leaks mapping was not durably appended");
360 + throw new NondurableAppendError(
361 + "leaks mapping was not durably appended",
362 + );
361 365 } catch (error) {
362 - state.tainted = true;
366 + if (!(error instanceof NondurableAppendError)) state.tainted = true;
363 367 throw error;